Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix media upload URI when API endpoint is overridden with client_opions.api_endpoint #1992

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

prkb
Copy link
Contributor

@prkb prkb commented Dec 5, 2022

This can happen when using Private Service Connect to access the APIs.

Fixes #1991

…ons.api_endpoint

This can happen when using Private Service Connect to access the APIs.
@prkb prkb requested a review from a team as a code owner December 5, 2022 22:14
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 5, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Dec 5, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@parthea parthea changed the title Fix media upload URI when API endpoint is overridden with client_opions.api_endpoint fix: Fix media upload URI when API endpoint is overridden with client_opions.api_endpoint Dec 6, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 6, 2022
@parthea parthea merged commit d0f8a05 into googleapis:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media upload URI does not respect overrides client_opions.api_endpoint
3 participants