Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for the release 1.4.2. #134

Merged
merged 4 commits into from
Sep 11, 2015

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Sep 11, 2015

Bumped the version number and added an entry in CHANGELOG.

I will appreciate if @nathanielmanistaatgoogle or @craigcitro can take a look.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2015
@craigcitro
Copy link
Contributor

I think you need to update the docs, too. (Maybe this is tox -e docs?)

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 11, 2015

I see. I think this is make docs. Let me know if I'm doing wrong.

@nathanielmanistaatgoogle
Copy link
Contributor

Also please follow the pattern of https://github.com/google/google-api-python-client/commits/eee38fa9d5e67df28bbb7f9321f - one commit for the change to __init__.py, one commit for the docs, and then one commit for the CHANGELOG change.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 11, 2015

Split it to 3 commits. PTAL

@craigcitro
Copy link
Contributor

ah, right, we converted google/oauth2client to sphinx but not this repo.

LGTM.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 11, 2015

Maybe I can update the Makefile to use twine to upload to pypi. Also how about to add wheel distribution?

@craigcitro
Copy link
Contributor

+1 on wheels.

On Fri, Sep 11, 2015 at 2:20 PM, Takashi Matsuo notifications@github.com
wrote:

Maybe I can update the Makefile to use twine to upload to pypi. Also how
about to add wheel distribution?


Reply to this email directly or view it on GitHub
#134 (comment)
.

-cc

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 11, 2015

Changed the Makefile to use twine and added wheel distribution. PTAL.

@craigcitro
Copy link
Contributor

lgtm -- i'll let @nathanielmanistaatgoogle merge.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 11, 2015

Let me add one more change before merge

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 11, 2015

Ok, I just added --universal flag to the bdist-wheel command so that the generated package can be used with either of Python 2 or 3.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 11, 2015

OK. Sorry for the last minutes updates. I think it's really ready. @nathanielmanistaatgoogle PTAL and merge if looks good. Thx!

@nathanielmanistaatgoogle
Copy link
Contributor

Looks great; merging.

Thanks for joining the team!

@pferate
Copy link
Contributor

pferate commented Oct 12, 2015

I added the content of docs to the gh-pages branch in PR #144

akrherz pushed a commit to akrherz/google-api-python-client that referenced this pull request Apr 1, 2019
Fall back to using an access_token for revocation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants