Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in resumable upload handler #312

Merged
merged 6 commits into from
Dec 20, 2016
Merged

Fix error in resumable upload handler #312

merged 6 commits into from
Dec 20, 2016

Conversation

mattcarrollcode
Copy link
Contributor

@mattcarrollcode mattcarrollcode commented Nov 28, 2016

The client library depends on the range header being in the response when the HTTP response code is 308, but the range header is not present in the response when the server hasn't received any bytes previously. This PR defaults to 0 in that case.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 28, 2016
@theacodes
Copy link
Contributor

@matthewayne it would be great if you could also update the test cases to cover this situation.

Copy link

@bjwatson bjwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a PR description for context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants