Fix method doc signatures for multiline required parameters #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing doc generator failed to recognize parameters as required when parameter descriptions extended over more than one line. Besides presenting incorrect information, resulting inconsistencies broke checks for automated sample generation.
googlebot
added
the
cla: yes
|
Note for review: manual changes in first commit, autogenerated doc update in second commit. |
|
I lack permissions to assign reviewers ... @jonparrott @saicheems please take a look. CC @vchudnov-g |
saicheems
reviewed
Mar 25, 2017
| @@ -105,11 +105,11 @@ | |||
| "clientAccountId": "A String", # Numerical account ID of the client buyer | |||
| # that the invited user is associated with. | |||
| # The value of this field is ignored in create operations. | |||
| "invitationId": "A String", # The unique numerical ID of the invitation that is sent to the user. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Mar 27, 2017
|
LGTM, let me know when you want to merge. |
|
@jonparrott Please go ahead and merge; I will investigate the ordering issue @saicheems brings up (to reduce diff noise, I presume). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing doc generator failed to recognize parameters as required when parameter descriptions extended over more than one line. Besides presenting incorrect information, resulting inconsistencies broke checks for automated sample generation.