Match travis matrix with tox testenv #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executing tox in the project directory is not the same of what is being executed in travis-ci This cause problems when replacing oauth2client library by google-auth in the setup.py because oauth2client is mandatory for tests, and travis was not installing oauth2client if it is not in the setup.py. Also it is good to keep the consistency of the test environments.
googlebot
added
the
cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing tox in the project directory is not the same of what is being
executed in travis-ci
It was causing problems when replacing oauth2client library by google-auth
in the setup.py because oauth2client is mandatory for tests, and travis
was not installing oauth2client if it is not in the setup.py.
Also it is good to keep the consistency of the test environments.