Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pycrypto. #692

Closed
wants to merge 3 commits into from
Closed

Remove pycrypto. #692

wants to merge 3 commits into from

Conversation

busunkim96
Copy link
Contributor

Closes #653.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2019
@theacodes
Copy link
Contributor

Honestly both of these libraries are problematic. We should just move to cryptography.

@busunkim96 busunkim96 changed the title Use pycryptodome instead of pycrypto. Use cryptography instead of pycrypto. Jun 10, 2019
@theacodes
Copy link
Contributor

Well now I'm curious what the dependency was doing at all. 🤷‍♀

@busunkim96
Copy link
Contributor Author

:) I was about to ask what pycrypto was used for.

There are 3 places PyCrypto is mentioned:

  1. tox.ini
  2. README as a development dependency
  3. Changelog:
    v1.1
    Version 1.1
    Add PEM support to SignedJWTAssertionCredentials (used to only support
    PKCS12 formatted keys). Note that if you use PEM formatted keys you can use
    PyCrypto 2.6 or later instead of OpenSSL.

If you don't have any concerns, I'll probably delete it. 🤷‍♀️

@theacodes
Copy link
Contributor

theacodes commented Jun 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change dependency from pycrypto
4 participants