Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass library and Python version in x-goog-api-client #734

Merged
merged 6 commits into from Aug 9, 2019

Conversation

@busunkim96
Copy link
Contributor

commented Aug 5, 2019

Closes #729

@googlebot googlebot added the cla: yes label Aug 5, 2019
@busunkim96 busunkim96 requested a review from dazuma Aug 5, 2019
googleapiclient/model.py Outdated Show resolved Hide resolved
tests/test_json_model.py Outdated Show resolved Hide resolved
tests/test_http.py Outdated Show resolved Hide resolved
@dazuma
dazuma approved these changes Aug 5, 2019
@busunkim96 busunkim96 requested a review from googleapis/yoshi-python Aug 5, 2019
googleapiclient/model.py Show resolved Hide resolved
tests/test_json_model.py Show resolved Hide resolved
@tseaver
tseaver approved these changes Aug 9, 2019
busunkim96 added 3 commits Aug 9, 2019
@busunkim96 busunkim96 merged commit 07f647c into googleapis:master Aug 9, 2019
2 checks passed
2 checks passed
Kokoro CI Build successful
Details
cla/google All necessary CLAs are signed
@asiunov

This comment has been minimized.

Copy link

commented Aug 13, 2019

@busunkim96 @tseaver @dazuma
seems like this PR introduces some regression. I started to get a signature mismatch when use this sdk (on .get_media method):

W0813 19:40:45.663586 1 http.py:118] Invalid JSON content from response: b"<?xml version='1.0' encoding='UTF-8'?><Error><Code>SignatureDoesNotMatch</Code><Message>The request signature we calculated does not match the signature you provided. Check your Google secret key and signing method.</Message><StringToSign>GET\n\n\n1565725545\nx-goog-api-client:gdcl/1.7.11 gl-python/3.7.4\n/...</StringToSign></Error>"
@busunkim96

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@asiunov Thank you for the report! Could you let us know which API you are using? (A small sample would also be much appreciated).

I see a similar error mentioned for node, but am unsure if this is the same cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.