New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google::Apis::OS_VERSION includes new line on Linux #645

Closed

zstewar1 opened this issue Jan 3, 2018 · 2 comments

Assignees

zstewar1 commented Jan 3, 2018

Google::Apis::OS_VERSION includes a newline on Linux.

https://github.com/google/google-api-ruby-client/blob/38e271cfb4532d61b857f624478108592288da06/lib/google/apis/version.rb#L33

This results in generating a user agent string which is not valid -- it inculdes the new line in the user agent string.
https://github.com/google/google-api-ruby-client/blob/b35f5face3649f25a4f24413b1fc9288f8bbe732/lib/google/apis/core/base_service.rb#L432

The text was updated successfully, but these errors were encountered:

roodion mentioned this issue

Trim spaces & new line for OS_VERSION #654

Closed

roodion commented Feb 23, 2018

Have prepared related PR #654

Contributor

mattwhisenhunt commented Apr 20, 2018

Fixed by #648

mattwhisenhunt closed this as completed

JustinBeckwith assigned mattwhisenhunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment