Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rexml as a runtime dependency #11024

Closed
wants to merge 1 commit into from

Conversation

ekohl
Copy link

@ekohl ekohl commented Jul 13, 2022

This was added in 660a798 (see #871 as well), but I can't reproduce the failure. I also can't find out where rexml was used in the past.

This was added in 660a798, but I can't
reproduce the failure. I also can't find out where rexml was used in the
past.
@ekohl ekohl requested a review from a team as a code owner July 13, 2022 20:44
@google-cla
Copy link

google-cla bot commented Jul 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ekohl
Copy link
Author

ekohl commented Jul 13, 2022

Before I sign any CLA I would like to know if this is even valid, or if I'm just missing something where it is needed.

@bajajneha27
Copy link
Contributor

Hi @ekohl
Help me understand, are you saying that you tried removing this gem and you couldn't reproduce the failure? Can you please also tell me how you tried to check for failures?

@ekohl
Copy link
Author

ekohl commented Aug 25, 2022

I've tried to look at the git history to see why it was added. It clearly was added, likely because of some failure. However, now removing the dependency still passes the test suite so I'd think it's redundant. Having fewer dependencies is better so I'd like to see it dropped.

Does that clarify things?

@bajajneha27
Copy link
Contributor

Thanks for clarifying!
Can you please sign the CLA for us to proceed with the PR?

@ekohl
Copy link
Author

ekohl commented Oct 4, 2022

I would need to discuss that with legal. Is there a chance you could submit a similar PR with these changes instead?

@bajajneha27
Copy link
Contributor

Sure. We'll try to cover this in a separate PR. Closing this one. Thank you!

@ekohl ekohl deleted the remove-rexml-dependency branch December 14, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants