samples(web): Fix the outdated web sample #13338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
bajajneha27
force-pushed
the
web-samples
branch
from
8c519dd
to
09ee75b
Compare
dazuma
reviewed
Feb 7, 2023
| validator = GoogleIDToken::Validator.new | ||
| claim = validator.check(params['id_token'], audience, audience) | ||
| claim = validator.check(params['credential'], audience, audience) |
There was a problem hiding this comment.
We should probably also remove the dependency on google-id-token and instead use the classes in googleauth.
There was a problem hiding this comment.
The ID token change will happen in a separate pull request, as agreed.
dazuma
approved these changes
Feb 8, 2023
| validator = GoogleIDToken::Validator.new | ||
| claim = validator.check(params['id_token'], audience, audience) | ||
| claim = validator.check(params['credential'], audience, audience) |
There was a problem hiding this comment.
The ID token change will happen in a separate pull request, as agreed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.