-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve errors and warnings related to ADC #1172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nit: The second item in the description needs to be removed if we only fix the missing credentials error in this PR |
Updated the PR description, this PR covers both items |
PTAL latest version - left the second part as we decided to keep it |
This change is part of the bigger work go/simplified-local-adc
Here we improve couple errors: