Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to suppress end user credentials warning. #207

Merged

Conversation

lbergelson
Copy link
Contributor

Defining a new environment variable SUPPRESS_GCLOUD_CREDS_WARNING.
Setting this to true suppresses the end user credentials warning.

Fixes #193

Defining a new environment variable SUPPRESS_GCLOUD_CREDS_WARNING.
Setting this to true suppresses the end user credentials warning.
Fixes googleapis#193
@lbergelson lbergelson requested a review from a team as a code owner November 9, 2018 18:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2018
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@eb7e845). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #207   +/-   ##
=========================================
  Coverage          ?   75.86%           
  Complexity        ?      314           
=========================================
  Files             ?       20           
  Lines             ?     1355           
  Branches          ?      149           
=========================================
  Hits              ?     1028           
  Misses            ?      254           
  Partials          ?       73
Impacted Files Coverage Δ Complexity Δ
...google/auth/oauth2/DefaultCredentialsProvider.java 79.82% <100%> (ø) 33 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7e845...320c13b. Read the comment docs.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2018
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 13, 2018
@chingor13 chingor13 merged commit 4598c3f into googleapis:master Nov 13, 2018
@lbergelson lbergelson deleted the lb_option_to_suppress_warning_message branch November 14, 2018 16:22
@lbergelson
Copy link
Contributor Author

@chingor13 Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants