-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImpersonatedCredentials #211
Add ImpersonatedCredentials #211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=========================================
Coverage ? 76.03%
Complexity ? 327
=========================================
Files ? 21
Lines ? 1456
Branches ? 158
=========================================
Hits ? 1107
Misses ? 270
Partials ? 79
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
this.sourceCredentials = this.sourceCredentials.createScoped(Arrays.asList(CLOUD_PLATFORM_SCOPE)); | ||
this.sourceCredentials.refresh(); | ||
} | ||
if (this.sourceCredentials.getAccessToken().getExpirationTime().before(new Date())) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I can handle any other cleanup separately.
Addresses #210
Allow for
ImpersonatedCredentials
in core auth library set. Instructions to repro or to run system tests:output of unittests ran: