Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: follow up fix service account credentials createScopedRequired #605

Merged
merged 2 commits into from Mar 18, 2021

Conversation

arithmetic1728
Copy link
Collaborator

@arithmetic1728 arithmetic1728 commented Mar 18, 2021

Address #601 (comment)

@arithmetic1728 arithmetic1728 requested a review from as a code owner Mar 18, 2021
@google-cla google-cla bot added the cla: yes label Mar 18, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 18, 2021

Codecov Report

Merging #605 (e5a3764) into master (3d066ee) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #605   +/-   ##
=========================================
  Coverage     83.59%   83.59%           
- Complexity      602      604    +2     
=========================================
  Files            42       42           
  Lines          2712     2712           
  Branches        289      289           
=========================================
  Hits           2267     2267           
  Misses          303      303           
  Partials        142      142           
Impacted Files Coverage Δ Complexity Δ
.../google/auth/oauth2/ServiceAccountCredentials.java 83.50% <100.00%> (ø) 67.00 <3.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d066ee...e5a3764. Read the comment docs.

@chingor13 chingor13 merged commit 7ddac43 into master Mar 18, 2021
15 checks passed
@chingor13 chingor13 deleted the jwt_fix branch Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants