Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migration tests in credentials module from JUnit4 to JUnit5 (#756) #761

Merged
merged 1 commit into from
Oct 8, 2021
Merged

chore: migration tests in credentials module from JUnit4 to JUnit5 (#756) #761

merged 1 commit into from
Oct 8, 2021

Conversation

Captain1653
Copy link
Contributor

It belongs to #756 . It's the second iteration. That's why I don't use fixed notation for the issue.

@Captain1653 Captain1653 requested a review from a team as a code owner October 8, 2021 19:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2021
@chanseokoh chanseokoh changed the title refactor: migration tests in credentials module from JUnit4 to JUnit5 (#756) chore: migration tests in credentials module from JUnit4 to JUnit5 (#756) Oct 8, 2021
@chanseokoh chanseokoh merged commit a64d35c into googleapis:main Oct 8, 2021
@Captain1653 Captain1653 deleted the credentials-junit-migration branch October 8, 2021 19:57
clundin25 added a commit to clundin25/google-auth-library-java that referenced this pull request Aug 9, 2022
Refactored tests added since 928dd04 to
use JUnit4 instead of JUnit5.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  sixth iteration (googleapis#756) (googleapis#769)"

This reverts commit 928dd04.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  fifth iteration (googleapis#756) (googleapis#767)"

This reverts commit 59dfb35.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  fourth iteration (googleapis#756) (googleapis#766)"

This reverts commit d7edc45.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  third iteration (googleapis#756) (googleapis#764)"

This reverts commit e9dfaf9.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (googleapis#756) (googleapis#763)"

This reverts commit d045247.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (googleapis#756) (googleapis#762)"

This reverts commit 4e6576f.

Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (googleapis#756) (googleapis#761)"

This reverts commit a64d35c.

Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (googleapis#756) (googleapis#760)"

This reverts commit cccaa44.
@clundin25 clundin25 mentioned this pull request Aug 9, 2022
4 tasks
clundin25 added a commit to clundin25/google-auth-library-java that referenced this pull request Aug 9, 2022
Refactored tests added since 928dd04 to
use JUnit4 instead of JUnit5.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  sixth iteration (googleapis#756) (googleapis#769)"

This reverts commit 928dd04.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  fifth iteration (googleapis#756) (googleapis#767)"

This reverts commit 59dfb35.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  fourth iteration (googleapis#756) (googleapis#766)"

This reverts commit d7edc45.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  third iteration (googleapis#756) (googleapis#764)"

This reverts commit e9dfaf9.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (googleapis#756) (googleapis#763)"

This reverts commit d045247.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (googleapis#756) (googleapis#762)"

This reverts commit 4e6576f.

Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (googleapis#756) (googleapis#761)"

This reverts commit a64d35c.

Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (googleapis#756) (googleapis#760)"

This reverts commit cccaa44.
clundin25 added a commit to clundin25/google-auth-library-java that referenced this pull request Aug 9, 2022
Refactored tests added since 928dd04 to
use JUnit4 instead of JUnit5.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  sixth iteration (googleapis#756) (googleapis#769)"

This reverts commit 928dd04.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  fifth iteration (googleapis#756) (googleapis#767)"

This reverts commit 59dfb35.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  fourth iteration (googleapis#756) (googleapis#766)"

This reverts commit d7edc45.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  third iteration (googleapis#756) (googleapis#764)"

This reverts commit e9dfaf9.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (googleapis#756) (googleapis#763)"

This reverts commit d045247.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (googleapis#756) (googleapis#762)"

This reverts commit 4e6576f.

Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (googleapis#756) (googleapis#761)"

This reverts commit a64d35c.

Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (googleapis#756) (googleapis#760)"

This reverts commit cccaa44.
clundin25 added a commit that referenced this pull request Aug 11, 2022
* refactor: Revert JUnit5 to JUnit4

Refactored tests added since 928dd04 to
use JUnit4 instead of JUnit5.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  sixth iteration (#756) (#769)"

This reverts commit 928dd04.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  fifth iteration (#756) (#767)"

This reverts commit 59dfb35.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  fourth iteration (#756) (#766)"

This reverts commit d7edc45.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 -  third iteration (#756) (#764)"

This reverts commit e9dfaf9.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (#756) (#763)"

This reverts commit d045247.

Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (#756) (#762)"

This reverts commit 4e6576f.

Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (#756) (#761)"

This reverts commit a64d35c.

Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (#756) (#760)"

This reverts commit cccaa44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants