chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fifth iteration (#756) #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
chanseokoh
approved these changes
Oct 13, 2021
Comment on lines
+790
to
+792
| OAuth2Credentials credentials = | ||
| OAuth2Credentials.newBuilder() | ||
| .setAccessToken(new AccessToken(ACCESS_TOKEN, null)) |
There was a problem hiding this comment.
This portion should better be taken out of the scope. However, since this doesn't change the semantics of the old code, this is fine.
clundin25
added a commit
to clundin25/google-auth-library-java
that referenced
this pull request
Aug 9, 2022
Refactored tests added since 928dd04 to use JUnit4 instead of JUnit5. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - sixth iteration (googleapis#756) (googleapis#769)" This reverts commit 928dd04. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fifth iteration (googleapis#756) (googleapis#767)" This reverts commit 59dfb35. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fourth iteration (googleapis#756) (googleapis#766)" This reverts commit d7edc45. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - third iteration (googleapis#756) (googleapis#764)" This reverts commit e9dfaf9. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (googleapis#756) (googleapis#763)" This reverts commit d045247. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (googleapis#756) (googleapis#762)" This reverts commit 4e6576f. Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (googleapis#756) (googleapis#761)" This reverts commit a64d35c. Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (googleapis#756) (googleapis#760)" This reverts commit cccaa44.
4 tasks
clundin25
added a commit
to clundin25/google-auth-library-java
that referenced
this pull request
Aug 9, 2022
Refactored tests added since 928dd04 to use JUnit4 instead of JUnit5. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - sixth iteration (googleapis#756) (googleapis#769)" This reverts commit 928dd04. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fifth iteration (googleapis#756) (googleapis#767)" This reverts commit 59dfb35. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fourth iteration (googleapis#756) (googleapis#766)" This reverts commit d7edc45. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - third iteration (googleapis#756) (googleapis#764)" This reverts commit e9dfaf9. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (googleapis#756) (googleapis#763)" This reverts commit d045247. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (googleapis#756) (googleapis#762)" This reverts commit 4e6576f. Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (googleapis#756) (googleapis#761)" This reverts commit a64d35c. Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (googleapis#756) (googleapis#760)" This reverts commit cccaa44.
clundin25
added a commit
to clundin25/google-auth-library-java
that referenced
this pull request
Aug 9, 2022
Refactored tests added since 928dd04 to use JUnit4 instead of JUnit5. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - sixth iteration (googleapis#756) (googleapis#769)" This reverts commit 928dd04. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fifth iteration (googleapis#756) (googleapis#767)" This reverts commit 59dfb35. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fourth iteration (googleapis#756) (googleapis#766)" This reverts commit d7edc45. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - third iteration (googleapis#756) (googleapis#764)" This reverts commit e9dfaf9. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (googleapis#756) (googleapis#763)" This reverts commit d045247. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (googleapis#756) (googleapis#762)" This reverts commit 4e6576f. Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (googleapis#756) (googleapis#761)" This reverts commit a64d35c. Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (googleapis#756) (googleapis#760)" This reverts commit cccaa44.
clundin25
added a commit
that referenced
this pull request
Aug 11, 2022
* refactor: Revert JUnit5 to JUnit4 Refactored tests added since 928dd04 to use JUnit4 instead of JUnit5. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - sixth iteration (#756) (#769)" This reverts commit 928dd04. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fifth iteration (#756) (#767)" This reverts commit 59dfb35. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fourth iteration (#756) (#766)" This reverts commit d7edc45. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - third iteration (#756) (#764)" This reverts commit e9dfaf9. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (#756) (#763)" This reverts commit d045247. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (#756) (#762)" This reverts commit 4e6576f. Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (#756) (#761)" This reverts commit a64d35c. Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (#756) (#760)" This reverts commit cccaa44.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It belongs to #756