refactor: Validate AWS Metadata URLs #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: - Validates a URL's `hostname` rather than`host` - Added test for URL with port - Uses static variables for AWS metadata IP Addresses - `RangeError` rather than `Error` - Separated validators from setters in `constructor`
sai-sunder-s
reviewed
Nov 8, 2022
| it('should support credential_source with a port number', () => { | ||
| const validCredentialSource = {...awsCredentialSource}; | ||
| const validURLWithPort = new URL(validCredentialSource.url); | ||
| validURLWithPort.port = '8888'; |
There was a problem hiding this comment.
I am not able to find any official aws documentatiton that says what ports are allowed. @lsirac any idea?
There was a problem hiding this comment.
I didn't see anything either; perhaps we can verify the hostname for now and if customers set a port we can allow it for now?
lsirac
approved these changes
Nov 8, 2022
sai-sunder-s
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
hostnamerather thanhostRangeErrorrather thanErrorconstructor