Support for ?scopes= in metadata server
#333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
ping |
sqrrrl
reviewed
Oct 21, 2019
| @@ -198,7 +201,7 @@ def get_service_account_token(request, service_account='default'): | |||
| """ | |||
| token_json = get( | |||
| request, | |||
| 'instance/service-accounts/{0}/token'.format(service_account)) | |||
| 'instance/service-accounts/{0}/token?scopes={1}'.format(service_account, ",".join(scopes))) | |||
|
I've since left Google, so I don't know what the internal status of this feature is or where the GCE or Client Lib team wants to go with it. Unless I get clear direction on that, I'll probably just close the PR and let them sort it out when they've prioritized it appropriately. |
|
Closing as this is superseded by #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for requesting access tokens with arbitrary metadata scopes from the compute metadata server.
Note: even though this feature is implemented in the metadata server, this feature is only available in the implementations on GAE Second Generation and GCF, not on GCE or GKE (where this functionality is already available by setting instance scopes).