Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signBytes for impersonated credentials #506

Merged
merged 3 commits into from
May 15, 2020
Merged

fix: signBytes for impersonated credentials #506

merged 3 commits into from
May 15, 2020

Conversation

maroux
Copy link
Contributor

@maroux maroux commented May 7, 2020

Fixes #338

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2020
@maroux maroux force-pushed the fix_impersonated_credentials_signbytes branch from cec645e to 2b85d0c Compare May 7, 2020 01:54
@arithmetic1728 arithmetic1728 self-requested a review May 7, 2020 17:11
@maroux maroux changed the title Fix signBytes for impersonated credentials fix: signBytes for impersonated credentials May 15, 2020
@maroux
Copy link
Contributor Author

maroux commented May 15, 2020

@arithmetic1728 can we get this merged please? Thanks!

@arithmetic1728 arithmetic1728 added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@arithmetic1728
Copy link
Contributor

@maroux It seems lint check failed in your PR. Could you run python -m nox -s blacken to fix the lint issue and commit the fix? Also
(1) run python -m nox -s lint to make sure the lint issue is solved
(2) run python -m nox -s cover to make sure the coverage is 100%

Thanks.

@maroux
Copy link
Contributor Author

maroux commented May 15, 2020

@arithmetic1728 done.

@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@arithmetic1728 arithmetic1728 merged commit ca8d98a into googleapis:master May 15, 2020
@maroux maroux deleted the fix_impersonated_credentials_signbytes branch May 15, 2020 22:58
@arithmetic1728
Copy link
Contributor

@maroux the fix is released in v1.15.0

@maroux
Copy link
Contributor Author

maroux commented May 18, 2020

awesome, thanks @arithmetic1728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google-cloud-storage: Cannot create signed url with ImpersonatedCredentials
4 participants
@maroux @arithmetic1728 @googlebot @yoshi-kokoro