Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signBytes for impersonated credentials #506

Merged
merged 3 commits into from
May 15, 2020
Merged

fix: signBytes for impersonated credentials #506

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b85d0c
fix: signBytes doesn't work for impersonated credentials
maroux May 7, 2020
03fe1c1
Merge branch 'master' into fix_impersonated_credentials_signbytes
maroux May 15, 2020
60744b7
black
maroux May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/auth/impersonated_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ def sign_bytes(self, message):

iam_sign_endpoint = _IAM_SIGN_ENDPOINT.format(self._target_principal)

body = {"payload": base64.b64encode(message), "delegates": self._delegates}
body = {"payload": base64.b64encode(message).decode("utf-8"), "delegates": self._delegates}

headers = {"Content-Type": "application/json"}

Expand Down