-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: session object was never used in aiohttp request (#700) #701
Merged
arithmetic1728
merged 5 commits into
googleapis:master
from
greshilov:fix-request-session-arg
Jun 3, 2021
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dfb2440
fix: session object was never used in aiohttp request (#700)
greshilov 556ca83
Merge branch 'master' into fix-request-session-arg
arithmetic1728 baf7d0c
fixup! fix: session object was never used in aiohttp request (#700)
greshilov a8137c9
fixup! fixup! fix: session object was never used in aiohttp request (…
greshilov 0de9cd1
Merge branch 'master' into fix-request-session-arg
arithmetic1728 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why raise the error here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifying the
session
object provided by the user is inappropriate in this place, so we can't disableauto_decompress
ourselves. Remaining options are:session
object provided by the user and leave theself.session = None
. Log error in console.session
.I chose the latter option because it's better to fail early in my opinion. A user may not notice that one's
session
object is ignored.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant why auto_decompress=True are not supported. I am not familiar with aiohttp.
I think in this PR you also need to pass
auto_decompress=False
to https://github.com/googleapis/google-auth-library-python/blob/master/system_tests/system_tests_async/conftest.py#L29 to make the system test work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah,
auto_decompress=True
is supported byaiohttp
, but this library prefers to do decompression on its own:google-auth-library-python/google/auth/transport/_aiohttp_requests.py
Lines 80 to 88 in 04c870a
I've made required changes in
conftest.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. Thank you! The system test is still failing. I will take a look at why it failed.