feat(cmake): automatically set ctype=CORD workarounds
#13877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Protobuf < v23.x (aka 4.23.x) we need to enable some ugly workarounds to use `ctype=CORD` fields in the storage library. With this change CMake automatically sets the workaround option if needed. Bazel assumes the version of Protobuf is >= v23 and disables the workarounds by default. That is reasonable because Bazel users update more often (or at least we believe that).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13877 +/- ##
==========================================
+ Coverage 93.04% 93.64% +0.60%
==========================================
Files 2178 2265 +87
Lines 185243 195574 +10331
==========================================
+ Hits 172353 183140 +10787
+ Misses 12890 12434 -456 ☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Mar 29, 2024
coryan
deleted the
feat-cmake-automatically-detect-ctype-cord-workaround
branch
7 tasks
JavierMatosD
pushed a commit
to microsoft/vcpkg
that referenced
this pull request
Apr 24, 2024
Updates google-cloud-cpp to the latest release (v2.23.0) Removed `DGOOGLE_CLOUD_CPP_ENABLE_CTYPE_CORD_WORKAROUND` since it is no longer used because it is automatically set now (googleapis/google-cloud-cpp#13877). Tested locally (on x64-linux) with: ``` for feature in "cloudcontrolspartner" "storagecontrol" "apphub" "backupdr"; do ./vcpkg remove google-cloud-cpp; ./vcpkg install "google-cloud-cpp[core,${feature}]" || break; done ``` and ``` ./vcpkg remove google-cloud-cpp && ./vcpkg install 'google-cloud-cpp[*]' ``` - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [x] SHA512s are updated for each updated download. - [x] The "supports" clause reflects platforms that may be fixed by this new version. - [x] Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file. - [x] Any patches that are no longer applied are deleted from the port's directory. - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Protobuf < v23.x (aka 4.23.x) we need to enable some ugly workarounds to use
ctype=CORDfields in the storage library. With this change CMake automatically sets the workaround option if needed. Bazel assumes the version of Protobuf is >= v23 and disables the workarounds by default. That is reasonable because Bazel users update more often (or at least we believe that).Part of the work for #13875
This change is