Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google-cloud-cpp] update to the latest release (v2.23) #38204

Merged

Conversation

alevenberg
Copy link
Contributor

Updates google-cloud-cpp to the latest release (v2.23.0)

Removed DGOOGLE_CLOUD_CPP_ENABLE_CTYPE_CORD_WORKAROUND since it is no longer used because it is automatically set now (googleapis/google-cloud-cpp#13877).

Tested locally (on x64-linux) with:

 for feature in "cloudcontrolspartner" "storagecontrol" "apphub" "backupdr"; do ./vcpkg remove google-cloud-cpp; ./vcpkg install "google-cloud-cpp[core,${feature}]" || break; done

and

./vcpkg remove google-cloud-cpp && ./vcpkg install 'google-cloud-cpp[*]'
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@alevenberg alevenberg force-pushed the google-cloud-cpp-update-to-v2.23 branch from 8fab892 to 8d89bee Compare April 15, 2024 23:22
@alevenberg alevenberg force-pushed the google-cloud-cpp-update-to-v2.23 branch 2 times, most recently from 2976098 to d4df16e Compare April 15, 2024 23:37
@dbolduc
Copy link
Contributor

dbolduc commented Apr 15, 2024

I am not sure what the build failure is. Does running the following make any changes? If so, try committing them.

./vcpkg x-add-version google-cloud-cpp --overwrite-version

@WangWeiLin-MV WangWeiLin-MV self-assigned this Apr 16, 2024
@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Apr 16, 2024
@alevenberg alevenberg force-pushed the google-cloud-cpp-update-to-v2.23 branch from d4df16e to b4f6728 Compare April 16, 2024 13:30
@alevenberg
Copy link
Contributor Author

I am not sure what the build failure is. Does running the following make any changes? If so, try committing them.

./vcpkg x-add-version google-cloud-cpp --overwrite-version

Fixed it thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenSSL is no longer a dependency on Windows (googleapis/google-cloud-cpp#13785).

@teo-tsirpanis
Copy link
Contributor

@alevenberg you need to run ./vcpkg x-add-version google-cloud-cpp --overwrite-version again and push a commit.

@alevenberg
Copy link
Contributor Author

@alevenberg you need to run ./vcpkg x-add-version google-cloud-cpp --overwrite-version again and push a commit.

Thanks. Done.

Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port usage tests pass with following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Apr 24, 2024
@JavierMatosD JavierMatosD merged commit ece635c into microsoft:master Apr 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants