Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl: add client origin metadata for a failed async unary rpc #14088

Merged
merged 4 commits into from
May 1, 2024
Merged

impl: add client origin metadata for a failed async unary rpc #14088

merged 4 commits into from
May 1, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Apr 29, 2024 •
edited
Loading

#13724

This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner April 29, 2024 20:44
dbolduc
dbolduc reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal isn't really a component. So we should just say impl: ...

google/cloud/internal/async_rpc_details.h Outdated Show resolved Hide resolved
google/cloud/internal/async_rpc_details.h Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (cb500d5) to head (8794171).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14088      +/-   ##
==========================================
+ Coverage   93.23%   93.78%   +0.55%     
==========================================
  Files        2197     2284      +87     
  Lines      188700   199146   +10446     
==========================================
+ Hits       175929   186768   +10839     
+ Misses      12771    12378     -393

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg changed the title impl(internal): change the error message for a failed async unary rpc impl: change the error message for a failed async unary rpc May 1, 2024
@alevenberg alevenberg changed the title impl: change the error message for a failed async unary rpc impl: add client origin metadata for a failed async unary rpc May 1, 2024
devbww
devbww approved these changes May 1, 2024
View reviewed changes
google/cloud/completion_queue_test.cc Outdated Show resolved Hide resolved
@alevenberg alevenberg enabled auto-merge (squash) May 1, 2024 19:21
@alevenberg alevenberg mentioned this pull request May 1, 2024
Closed
20 tasks
@alevenberg alevenberg merged commit 7c0c6dc into googleapis:main May 1, 2024
63 checks passed
@alevenberg alevenberg deleted the grpc-name branch May 1, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbolduc dbolduc dbolduc left review comments

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alevenberg @devbww @dbolduc