Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade grpc to v1.26.0 #3305

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Jan 6, 2020

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 6, 2020
@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #3305 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3305      +/-   ##
==========================================
- Coverage   90.14%   90.13%   -0.02%     
==========================================
  Files         457      457              
  Lines       41122    41117       -5     
==========================================
- Hits        37071    37059      -12     
- Misses       4051     4058       +7
Impacted Files Coverage Δ
...oogle/cloud/bigtable/internal/unary_client_utils.h 84.37% <0%> (-15.63%) ⬇️
google/cloud/storage/well_known_headers.h 77.77% <0%> (-14.82%) ⬇️
google/cloud/storage/internal/curl_handle.h 65.62% <0%> (-12.5%) ⬇️
google/cloud/bigtable/internal/common_client.h 89.47% <0%> (-10.53%) ⬇️
google/cloud/storage/internal/hash_validator.h 70% <0%> (-10%) ⬇️
google/cloud/storage/internal/common_metadata.h 97.05% <0%> (-0.77%) ⬇️
google/cloud/bigtable/metadata_update_policy.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/app_profile_config.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/mutations.h 100% <0%> (ø) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0004e...19dc10d. Read the comment docs.

@scotthart scotthart requested a review from coryan January 8, 2020 19:18
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scotthart scotthart merged commit aeaa065 into googleapis:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants