fix: do not use CURL_SHARE features #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems safer to stop using the CURL_SHARE features until curl/curl#4915 is fixed. We have outstanding bug reports of crashes in multi-threaded applications, and our own tests trigger errors when runing under ThreadSanitizer. I considered making this an optional feature, disabled by default, but the only case where this could be useful is a single-threaded application that starts multiple downloads at the same time, and the benefits in that case are (probably) very modest: the connection setup would be slightly faster, but everything else would be the same.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #3860 +/- ##
==========================================
- Coverage 92.49% 92.48% -0.02%
==========================================
Files 504 504
Lines 43190 43152 -38
==========================================
- Hits 39949 39907 -42
- Misses 3241 3245 +4
Continue to review full report at Codecov.
|
devbww
approved these changes
Apr 20, 2020
frankyn
pushed a commit
to frankyn/google-cloud-cpp
that referenced
this pull request
Apr 29, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.81.0](https://www.github.com/googleapis/google-cloud-go/compare/v0.80.0...v0.81.0) (2021-04-02) ### Features * **datacatalog:** Policy Tag Manager v1 API service feat: new RenameTagTemplateFieldEnumValue API feat: adding fully_qualified_name in lookup and search feat: added DATAPROC_METASTORE integrated system along with new entry types: DATABASE and SERVICE docs: Documentation improvements ([2b02a03](https://www.github.com/googleapis/google-cloud-go/commit/2b02a03ff9f78884da5a8e7b64a336014c61bde7)) * **dialogflow/cx:** include original user query in WebhookRequest; add GetTextCaseresult API. doc: clarify resource format for session response. ([a0b1f6f](https://www.github.com/googleapis/google-cloud-go/commit/a0b1f6faae77d014fdee166ab018ddcd6f846ab4)) * **dialogflow/cx:** include original user query in WebhookRequest; add GetTextCaseresult API. doc: clarify resource format for session response. ([b5b4da6](https://www.github.com/googleapis/google-cloud-go/commit/b5b4da6952922440d03051f629f3166f731dfaa3)) * **dialogflow:** expose MP3_64_KBPS and MULAW for output audio encodings. ([b5b4da6](https://www.github.com/googleapis/google-cloud-go/commit/b5b4da6952922440d03051f629f3166f731dfaa3)) * **secretmanager:** Rotation for Secrets ([2b02a03](https://www.github.com/googleapis/google-cloud-go/commit/2b02a03ff9f78884da5a8e7b64a336014c61bde7)) ### Bug Fixes * **internal/godocfx:** filter out non-Cloud ([googleapis#3878](https://www.github.com/googleapis/google-cloud-go/issues/3878)) ([625aef9](https://www.github.com/googleapis/google-cloud-go/commit/625aef9b47181cf627587cc9cde9e400713c6678)) This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems safer to stop using the CURL_SHARE features until
curl/curl#4915 is fixed. We have outstanding bug reports of crashes in
multi-threaded applications, and our own tests trigger errors when
runing under ThreadSanitizer. I considered making this an optional
feature, disabled by default, but the only case where this could be
useful is a single-threaded application that starts multiple downloads
at the same time, and the benefits in that case are (probably) very
modest: the connection setup would be slightly faster, but everything
else would be the same.
Part of the work for #3832
Updated the API baseline, all the changes are in the
::google::cloud::storage::internalnamespace.This change is