Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable integration tests for sanitizer builds #3832

Closed
4 tasks done
coryan opened this issue Apr 17, 2020 · 1 comment · Fixed by #3861
Closed
4 tasks done

Enable integration tests for sanitizer builds #3832

coryan opened this issue Apr 17, 2020 · 1 comment · Fixed by #3861
Assignees
@coryan
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Monorepo: Prepare...

Comments

@coryan
Copy link
Contributor

coryan commented Apr 17, 2020 •
edited
Loading

In -spanner and -pubsub we run the integration tests for all the sanitizer builds, whereas we do not do that in -cpp. It would be preferable not to lose these builds as we move code to -cpp.

  • asan
  • msan
  • tsan
  • ubsan
@coryan coryan added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 17, 2020
@coryan coryan self-assigned this Apr 17, 2020
This was referenced Apr 17, 2020
Merged
Merged
Merged
@coryan
Copy link
Contributor Author

coryan commented Apr 19, 2020

I think tsan and ubsan are going to be blocked by curl/curl#4915, unless we disable the shared cache when running under tsan.

This was referenced Apr 19, 2020
Merged
Merged
Merged
frankyn pushed a commit to frankyn/google-cloud-cpp that referenced this issue Apr 29, 2021
@yoshi-automation
chore(all): auto-regenerate gapics (googleapis#3832)
cb43066 
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.


Corresponding genproto PR: googleapis/go-genproto#553

Changes:

feat(documentai): add EVAL_SKIPPED value to the Provenance.OperationType enum in document.proto.
  PiperOrigin-RevId: 363478455
  Source-Link: googleapis/googleapis@4fb2f3e

build(metastore): update package name to correct name under which it is already released
  PiperOrigin-RevId: 363462594
  Source-Link: googleapis/googleapis@a941929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
Monorepo: Prepare builds for incoming...
Development

Successfully merging a pull request may close this issue.

feat: enable integration tests for tsan and ubsan builds coryan/google-cloud-cpp
1 participant
@coryan