feat(testbench): better emulation for XML requests #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I (coryan) did not know about host-based routing the XML emulation has used a different subdirectory `/xmlapi/`. The production service uses the `Host: ` header to resolve the bucket for XML requests, with this change the testbench does the same. The old `/xmlapi/` path is still working, I will remove it once the tests pass without it.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #5083 +/- ##
==========================================
+ Coverage 95.81% 95.82% +0.01%
==========================================
Files 983 985 +2
Lines 90069 90207 +138
==========================================
+ Hits 86301 86443 +142
+ Misses 3768 3764 -4
Continue to review full report at Codecov.
|
devbww
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I (coryan) did not know about host-based routing the XML
emulation has used a different subdirectory
/xmlapi/. The productionservice uses the
Host:header to resolve the bucket for XML requests,with this change the testbench does the same.
The old
/xmlapi/path is still working, I will remove it once thetests pass without it.
Part of the work for #5072 only tested manually so far.
This change is