Skip to content

Commit

Permalink
Use service version instead of name
Browse files Browse the repository at this point in the history
In [this refactor](6e34e22#diff-09fd4adfdaa66895eb50b1b0f516edd5b7464563e10b4df1f2266e17edc2f460L76-R81) `Project.GetServiceName` is accidentally used for the service _version_ rather than the `Project.GetServiceVersion` method. This causes Google Cloud Error Reporting to use the service name for both the name and version.
  • Loading branch information
henkmollema authored and amanda-tarafa committed Jan 13, 2022
1 parent b1398f1 commit 437e6c4
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -77,7 +77,7 @@ internal static IContextExceptionLogger Create(ErrorReportingServiceOptions opti

var serviceContext = CreateServiceContext(
Project.GetServiceName(options.ServiceName, errorReportingOptions.MonitoredResource),
Project.GetServiceName(options.Version, errorReportingOptions.MonitoredResource))
Project.GetServiceVersion(options.Version, errorReportingOptions.MonitoredResource))
?? new Struct();

IConsumer<LogEntry> consumer = LogConsumer.Create(client, errorReportingOptions.BufferOptions, errorReportingOptions.RetryOptions);
Expand Down

0 comments on commit 437e6c4

Please sign in to comment.