feat: Adds named reservation to InstancePolicy

--- docs:Remove "not yet implemented" for Accelerator & Refine Volume API docs --- docs: update the job id format requirement PiperOrigin-RevId: 489502315 Source-Link: googleapis/googleapis@db1cc11 Source-Link: googleapis/googleapis-gen@fcc564e Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQmF0Y2guVjEvLk93bEJvdC55YW1sIiwiaCI6ImZjYzU2NGVmMDY0YzdkZmYzMWQ3OTcwZTEyMzE4YWQwODQ3MDNhYzYifQ==
googleapis · Nov 18, 2022 · ad603eb · ad603eb
1 parent 9072a1f
commit ad603eb
Show file tree

Hide file tree

Showing 5 changed files with 49 additions and 39 deletions.
diff --git a/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/Batch.g.cs b/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/Batch.g.cs
@@ -172,8 +172,9 @@ public sealed partial class CreateJobRequest : pb::IMessage<CreateJobRequest>
     private string jobId_ = "";
     /// <summary>
     /// ID used to uniquely identify the Job within its parent scope.
-    /// This field should contain at most 63 characters.
-    /// Only alphanumeric characters or '-' are accepted.
+    /// This field should contain at most 63 characters and must start with
+    /// lowercase characters.
+    /// Only lowercase characters, numbers and '-' are accepted.
     /// The '-' character cannot be the first or the last one.
     /// A system generated ID will be used if the field is not set.
     ///

diff --git a/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/BatchServiceClient.g.cs b/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/BatchServiceClient.g.cs
@@ -375,8 +375,9 @@ internal static BatchServiceClient Create(grpccore::CallInvoker callInvoker, Bat
         /// </param>
         /// <param name="jobId">
         /// ID used to uniquely identify the Job within its parent scope.
-        /// This field should contain at most 63 characters.
-        /// Only alphanumeric characters or '-' are accepted.
+        /// This field should contain at most 63 characters and must start with
+        /// lowercase characters.
+        /// Only lowercase characters, numbers and '-' are accepted.
         /// The '-' character cannot be the first or the last one.
         /// A system generated ID will be used if the field is not set.
         /// 
@@ -405,8 +406,9 @@ internal static BatchServiceClient Create(grpccore::CallInvoker callInvoker, Bat
         /// </param>
         /// <param name="jobId">
         /// ID used to uniquely identify the Job within its parent scope.
-        /// This field should contain at most 63 characters.
-        /// Only alphanumeric characters or '-' are accepted.
+        /// This field should contain at most 63 characters and must start with
+        /// lowercase characters.
+        /// Only lowercase characters, numbers and '-' are accepted.
         /// The '-' character cannot be the first or the last one.
         /// A system generated ID will be used if the field is not set.
         /// 
@@ -435,8 +437,9 @@ internal static BatchServiceClient Create(grpccore::CallInvoker callInvoker, Bat
         /// </param>
         /// <param name="jobId">
         /// ID used to uniquely identify the Job within its parent scope.
-        /// This field should contain at most 63 characters.
-        /// Only alphanumeric characters or '-' are accepted.
+        /// This field should contain at most 63 characters and must start with
+        /// lowercase characters.
+        /// Only lowercase characters, numbers and '-' are accepted.
         /// The '-' character cannot be the first or the last one.
         /// A system generated ID will be used if the field is not set.
         /// 
@@ -460,8 +463,9 @@ internal static BatchServiceClient Create(grpccore::CallInvoker callInvoker, Bat
         /// </param>
         /// <param name="jobId">
         /// ID used to uniquely identify the Job within its parent scope.
-        /// This field should contain at most 63 characters.
-        /// Only alphanumeric characters or '-' are accepted.
+        /// This field should contain at most 63 characters and must start with
+        /// lowercase characters.
+        /// Only lowercase characters, numbers and '-' are accepted.
         /// The '-' character cannot be the first or the last one.
         /// A system generated ID will be used if the field is not set.
         /// 
@@ -490,8 +494,9 @@ internal static BatchServiceClient Create(grpccore::CallInvoker callInvoker, Bat
         /// </param>
         /// <param name="jobId">
         /// ID used to uniquely identify the Job within its parent scope.
-        /// This field should contain at most 63 characters.
-        /// Only alphanumeric characters or '-' are accepted.
+        /// This field should contain at most 63 characters and must start with
+        /// lowercase characters.
+        /// Only lowercase characters, numbers and '-' are accepted.
         /// The '-' character cannot be the first or the last one.
         /// A system generated ID will be used if the field is not set.
         /// 
@@ -520,8 +525,9 @@ internal static BatchServiceClient Create(grpccore::CallInvoker callInvoker, Bat
         /// </param>
         /// <param name="jobId">
         /// ID used to uniquely identify the Job within its parent scope.
-        /// This field should contain at most 63 characters.
-        /// Only alphanumeric characters or '-' are accepted.
+        /// This field should contain at most 63 characters and must start with
+        /// lowercase characters.
+        /// Only lowercase characters, numbers and '-' are accepted.
         /// The '-' character cannot be the first or the last one.
         /// A system generated ID will be used if the field is not set.
         /// 

diff --git a/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/Job.g.cs b/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/Job.g.cs
@@ -3409,7 +3409,7 @@ public enum DataSourceOneofCase {
       }
 
       /// <summary>
-      /// A new or an existing persistent disk or a local ssd attached to a VM
+      /// A new or an existing persistent disk (PD) or a local ssd attached to a VM
       /// instance.
       /// </summary>
       public sealed partial class AttachedDisk : pb::IMessage<AttachedDisk>
@@ -3731,7 +3731,7 @@ public enum AttachedOneofCase {
       }
 
       /// <summary>
-      /// Accelerator describes Compute Engine accelerators to be attached to VMs.
+      /// Accelerator describes Compute Engine accelerators to be attached to the VM.
       /// </summary>
       public sealed partial class Accelerator : pb::IMessage<Accelerator>
       #if !GOOGLE_PROTOBUF_REFSTRUCT_COMPATIBILITY_MODE
@@ -4114,7 +4114,6 @@ public sealed partial class InstancePolicy : pb::IMessage<InstancePolicy>
         private readonly pbc::RepeatedField<global::Google.Cloud.Batch.V1.AllocationPolicy.Types.Accelerator> accelerators_ = new pbc::RepeatedField<global::Google.Cloud.Batch.V1.AllocationPolicy.Types.Accelerator>();
         /// <summary>
         /// The accelerators attached to each VM instance.
-        /// Not yet implemented.
         /// </summary>
         [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
         [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -4129,7 +4128,7 @@ public sealed partial class InstancePolicy : pb::IMessage<InstancePolicy>
         private readonly pbc::RepeatedField<global::Google.Cloud.Batch.V1.AllocationPolicy.Types.AttachedDisk> disks_ = new pbc::RepeatedField<global::Google.Cloud.Batch.V1.AllocationPolicy.Types.AttachedDisk>();
         /// <summary>
         /// Non-boot disks to be attached for each VM created by this InstancePolicy.
-        /// New disks will be deleted when the attached VM is deleted.
+        /// New disks will be deleted when the VM is deleted.
         /// </summary>
         [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
         [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]

diff --git a/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/Task.g.cs b/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/Task.g.cs
@@ -1907,7 +1907,7 @@ public sealed partial class Container : pb::IMessage<Container>
         private string username_ = "";
         /// <summary>
         /// Optional username for logging in to a docker registry. If username
-        /// matches `projects/*/secrets/*/versions/*` then Batch will read the
+        /// matches "projects/*/secrets/*/versions/*" then Batch will read the
         /// username from the Secret Manager.
         /// </summary>
         [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
@@ -1924,7 +1924,7 @@ public sealed partial class Container : pb::IMessage<Container>
         private string password_ = "";
         /// <summary>
         /// Optional password for logging in to a docker registry. If password
-        /// matches `projects/*/secrets/*/versions/*` then Batch will read the
+        /// matches "projects/*/secrets/*/versions/*" then Batch will read the
         /// password from the Secret Manager;
         /// </summary>
         [global::System.Diagnostics.DebuggerNonUserCodeAttribute]

diff --git a/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/Volume.g.cs b/apis/Google.Cloud.Batch.V1/Google.Cloud.Batch.V1/Volume.g.cs
@@ -49,9 +49,7 @@ public static partial class VolumeReflection {
   }
   #region Messages
   /// <summary>
-  /// Volume and mount parameters to be associated with a TaskSpec. A TaskSpec
-  /// might describe zero, one, or multiple volumes to be mounted as part of the
-  /// task.
+  /// Volume describes a volume and parameters for it to be mounted to a VM.
   /// </summary>
   public sealed partial class Volume : pb::IMessage<Volume>
   #if !GOOGLE_PROTOBUF_REFSTRUCT_COMPATIBILITY_MODE
@@ -113,7 +111,8 @@ public sealed partial class Volume : pb::IMessage<Volume>
     /// <summary>Field number for the "nfs" field.</summary>
     public const int NfsFieldNumber = 1;
     /// <summary>
-    /// An NFS source for the volume (could be a Filestore, for example).
+    /// A Network File System (NFS) volume. For example, a
+    /// Filestore file share.
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -128,7 +127,7 @@ public sealed partial class Volume : pb::IMessage<Volume>
     /// <summary>Field number for the "gcs" field.</summary>
     public const int GcsFieldNumber = 3;
     /// <summary>
-    /// A Google Cloud Storage source for the volume.
+    /// A Google Cloud Storage (GCS) volume.
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -143,7 +142,11 @@ public sealed partial class Volume : pb::IMessage<Volume>
     /// <summary>Field number for the "device_name" field.</summary>
     public const int DeviceNameFieldNumber = 6;
     /// <summary>
-    /// Device name of an attached disk
+    /// Device name of an attached disk volume, which should align with a
+    /// device_name specified by
+    /// job.allocation_policy.instances[0].policy.disks[i].device_name or
+    /// defined by the given instance template in
+    /// job.allocation_policy.instances[0].instance_template.
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -159,7 +162,7 @@ public sealed partial class Volume : pb::IMessage<Volume>
     public const int MountPathFieldNumber = 4;
     private string mountPath_ = "";
     /// <summary>
-    /// Mount path for the volume, e.g. /mnt/share
+    /// The mount path for the volume, e.g. /mnt/disks/share.
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -176,14 +179,15 @@ public sealed partial class Volume : pb::IMessage<Volume>
         = pb::FieldCodec.ForString(42);
     private readonly pbc::RepeatedField<string> mountOptions_ = new pbc::RepeatedField<string>();
     /// <summary>
-    /// Mount options
-    /// For Google Cloud Storage, mount options are the global options supported by
-    /// gcsfuse tool. Batch will use them to mount the volume with the following
-    /// command:
-    /// "gcsfuse [global options] bucket mountpoint".
-    /// For PD, NFS, mount options are these supported by /etc/fstab. Batch will
-    /// use Fstab to mount such volumes.
-    /// https://help.ubuntu.com/community/Fstab
+    /// For Google Cloud Storage (GCS), mount options are the options supported by
+    /// the gcsfuse tool (https://github.com/GoogleCloudPlatform/gcsfuse).
+    /// For existing persistent disks, mount options provided by the
+    /// mount command (https://man7.org/linux/man-pages/man8/mount.8.html) except
+    /// writing are supported. This is due to restrictions of multi-writer mode
+    /// (https://cloud.google.com/compute/docs/disks/sharing-disks-between-vms).
+    /// For other attached disks and Network File System (NFS), mount options are
+    /// these supported by the mount command
+    /// (https://man7.org/linux/man-pages/man8/mount.8.html).
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -464,7 +468,7 @@ public enum SourceOneofCase {
   }
 
   /// <summary>
-  /// Represents an NFS server and remote path: &lt;server>:&lt;remote_path>
+  /// Represents an NFS volume.
   /// </summary>
   public sealed partial class NFS : pb::IMessage<NFS>
   #if !GOOGLE_PROTOBUF_REFSTRUCT_COMPATIBILITY_MODE
@@ -515,7 +519,7 @@ public sealed partial class NFS : pb::IMessage<NFS>
     public const int ServerFieldNumber = 1;
     private string server_ = "";
     /// <summary>
-    /// URI of the NFS server, e.g. an IP address.
+    /// The IP address of the NFS.
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -530,7 +534,7 @@ public sealed partial class NFS : pb::IMessage<NFS>
     public const int RemotePathFieldNumber = 2;
     private string remotePath_ = "";
     /// <summary>
-    /// Remote source path exported from NFS, e.g., "/share".
+    /// Remote source path exported from the NFS, e.g., "/share".
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -699,7 +703,7 @@ public sealed partial class NFS : pb::IMessage<NFS>
   }
 
   /// <summary>
-  /// Represents a Google Cloud Storage volume source config.
+  /// Represents a Google Cloud Storage volume.
   /// </summary>
   public sealed partial class GCS : pb::IMessage<GCS>
   #if !GOOGLE_PROTOBUF_REFSTRUCT_COMPATIBILITY_MODE