Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoogleStackdriverAppender doesn't allow for custom credentials #2314

Closed
eug48 opened this issue Jul 6, 2018 · 2 comments
Closed

GoogleStackdriverAppender doesn't allow for custom credentials #2314

eug48 opened this issue Jul 6, 2018 · 2 comments
Assignees
@chrisdunelm
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@eug48
Copy link

eug48 commented Jul 6, 2018

There is a CredentialFile property but please consider something like CredentialJson or a more generic Credential. That would be useful for loading the credential data for example from encrypted storage, DPAPI, or some vault rather than from a plain file on disk.

Thanks!

https://github.com/GoogleCloudPlatform/google-cloud-dotnet/blob/master/apis/Google.Cloud.Logging.Log4Net/Google.Cloud.Logging.Log4Net/GoogleStackdriverAppender.cs#L204
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Jul 7, 2018
@chrisdunelm chrisdunelm self-assigned this Jul 10, 2018
@chrisdunelm chrisdunelm added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 10, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Jul 10, 2018
chrisdunelm added a commit to chrisdunelm/google-cloud-dotnet that referenced this issue Jul 10, 2018
@chrisdunelm
Support JSON credentials in log4net
027e209 
Fixes googleapis#2314
@chrisdunelm chrisdunelm mentioned this issue Jul 10, 2018
Merged
@chrisdunelm
Copy link
Contributor

Not including support for the more generic GoogleCredential, as we don't want to have any direct dependencies from libraries in this repo to auth in the Google.Apis.Auth package.

chrisdunelm added a commit that referenced this issue Jul 10, 2018
@chrisdunelm
Support JSON credentials in log4net (#2322)
b36872c 
Fixes #2314
@chrisdunelm
Copy link
Contributor

Now release to nuget.org as 2.3.0-beta01

@snakefoot snakefoot mentioned this issue Jul 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdunelm chrisdunelm

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisdunelm @JustinBeckwith @eug48