Operation.PollUntilCompleted duplicates version header #3029
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
We provide a convenience method on
Operation<TResult, TMetadata>
to automatically poll the operation until it has completed. That method takes aCallSettings
as normal, but it has to take account of things in a slightly different way. It needs the effective call settings forGetOperation
so it can apply the earlier of "per method call deadline" or "overall deadline" (like an internal retry does) - so we have a special method inOperationsClient
ofGetEffectiveCallSettingsForGetOperation(CallSettings)
.The polling code uses this to obtain a
CallSettings
, but then passes that to the normalGetOperation
method (indirectly), which merges it with the default settings. That means the header mutation action happens twice :( We effectively want to say "use these exact call settings, don't merge them with anything". I think.The text was updated successfully, but these errors were encountered: