Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spanner] feat: set resource header in streaming method #5255

Merged

Conversation

skuruppu
Copy link
Contributor

Sets the google-cloud-resource-prefix header when calling the ExecuteStreamingSql RPC in the Spanner data client so that we can support resource-based routing.

Towards #5181

@skuruppu skuruppu added the api: spanner Issues related to the Spanner API. label Aug 19, 2020
@skuruppu skuruppu requested a review from jskeet August 19, 2020 02:37
@skuruppu skuruppu requested a review from a team as a code owner August 19, 2020 02:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2020
@skuruppu skuruppu force-pushed the spanner-resource-prefix-header-streaming branch from 1e2a162 to 3c21898 Compare August 19, 2020 02:40
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but otherwise looks good - that's rather simpler than I'd expected :)

Sets the google-cloud-resource-prefix header when calling the ExecuteStreamingSql RPC in the Spanner data client so that we can support resource-based routing.

Towards googleapis#5181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants