Skip to content

Commit

Permalink
fix: refactor to apiv2
Browse files Browse the repository at this point in the history
  • Loading branch information
noahdietz committed Jul 15, 2021
1 parent 3e54d74 commit d10fffb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions storage/reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (

"cloud.google.com/go/internal/trace"
"google.golang.org/api/googleapi"
storagepb "google.golang.org/genproto/googleapis/storage/v1"
storagepb "google.golang.org/genproto/googleapis/storage/v2"
)

var crc32cTable = crc32.MakeTable(crc32.Castagnoli)
Expand Down Expand Up @@ -100,14 +100,14 @@ func (o *ObjectHandle) NewRangeReaderWithGRPC(ctx context.Context, offset, lengt
return
}

req := &storagepb.GetObjectMediaRequest{
req := &storagepb.ReadObjectRequest{
Bucket: o.bucket,
Object: o.object,
}

// Define a function that initiates a Read with offset and length, assuming we
// have already read seen bytes.
reopen := func(seen int64) (storagepb.Storage_GetObjectMediaClient, error) {
reopen := func(seen int64) (storagepb.Storage_ReadObjectClient, error) {
// If the context has already expired, return immediately without making a
// call.
if err := ctx.Err(); err != nil {
Expand All @@ -121,7 +121,7 @@ func (o *ObjectHandle) NewRangeReaderWithGRPC(ctx context.Context, offset, lengt
}
req.ReadOffset = start

res, err := o.c.gc.GetObjectMedia(ctx, req)
res, err := o.c.gc.ReadObject(ctx, req)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -400,8 +400,8 @@ type Reader struct {
gotCRC uint32 // running crc
reopen func(seen int64) (*http.Response, error)

stream storagepb.Storage_GetObjectMediaClient
reopenWithGRPC func(seen int64) (storagepb.Storage_GetObjectMediaClient, error)
stream storagepb.Storage_ReadObjectClient
reopenWithGRPC func(seen int64) (storagepb.Storage_ReadObjectClient, error)
leftovers []byte
}

Expand Down
2 changes: 1 addition & 1 deletion storage/storage.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import (
"cloud.google.com/go/internal/optional"
"cloud.google.com/go/internal/trace"
"cloud.google.com/go/internal/version"
gapic "cloud.google.com/go/storage/internal/apiv1"
gapic "cloud.google.com/go/storage/internal/apiv2"
"google.golang.org/api/googleapi"
"google.golang.org/api/option"
"google.golang.org/api/option/internaloption"
Expand Down

0 comments on commit d10fffb

Please sign in to comment.