Skip to content

Commit

Permalink
chore(ci): allowlist some dependencies (#9375)
Browse files Browse the repository at this point in the history
The `GoogleCloudPlatform` GitHub organization is a first party dependency and should be allowed.

Allowlist `cloudprober` as an internal module dependency: https://togithub.com/googleapis/google-cloud-go/issues/9377

Temporarily allowlist `rsc.io/binaryregexp` until we know next steps: https://togithub.com/googleapis/google-cloud-go/issues/9376

Temporarily allowlist `github.com/json-iterator/go` until we know next steps: https://togithub.com/googleapis/google-cloud-go/issues/9380

Temporarily allowlist `github.com/stretchr/testify` until we know next steps: https://togithub.com/googleapis/google-cloud-go/issues/9378
  • Loading branch information
noahdietz committed Feb 6, 2024
1 parent dc21234 commit efba04d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions go.work.sum
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ go.opentelemetry.io/otel/bridge/opencensus v0.40.0/go.mod h1:1NvVHb6tLTe5A9qCYz+
go.opentelemetry.io/proto/otlp v1.0.0/go.mod h1:Sy6pihPLfYHkr3NkUbEhGHFhINUSI/v80hjKIs5JXpM=
golang.org/x/mod v0.9.0 h1:KENHtAZL2y3NLMYZeHY9DW8HW8V+kQyJsY/V9JlKvCs=
golang.org/x/mod v0.11.0 h1:bUO06HqtnRcc/7l71XBe4WcqTZ+3AH1J59zWDDwLKgU=
golang.org/x/term v0.15.0/go.mod h1:BDl952bC7+uMoWR75FIrCDx79TPU9oHkTZ9yRbYOrX0=
golang.org/x/tools v0.7.0 h1:W4OVu8VVOaIO0yzWMNdepAulS7YfoS3Zabrm8DOXXU4=
golang.org/x/tools v0.10.0 h1:tvDr/iQoUqNdohiYm0LmmKcBk+q86lb9EprIUFhHHGg=
google.golang.org/api v0.157.0/go.mod h1:+z4v4ufbZ1WEpld6yMGHyggs+PmAHiaLNj5ytP3N01g=
Expand All @@ -38,4 +39,5 @@ google.golang.org/genproto/googleapis/api v0.0.0-20230725213213-b022f6e96895/go.
google.golang.org/genproto/googleapis/api v0.0.0-20240116215550-a9fa1716bcac/go.mod h1:B5xPO//w8qmBDjGReYLpR6UJPnkldGkCSMoH/2vxJeg=
google.golang.org/genproto/googleapis/bytestream v0.0.0-20231120223509-83a465c0220f/go.mod h1:iIgEblxoG4klcXsG0d9cpoxJ4xndv6+1FkDROCHhPRI=
google.golang.org/genproto/googleapis/bytestream v0.0.0-20240102182953-50ed04b92917/go.mod h1:O9TvT7A9NLgdqqF0JJXJ+axpaoYiEb8txGmkvy+AvLc=
google.golang.org/genproto/googleapis/bytestream v0.0.0-20240125205218-1f4bbc51befe/go.mod h1:SCz6T5xjNXM4QFPRwxHcfChp7V+9DcXR3ay2TkHR8Tg=
google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895/go.mod h1:TUfxEVdsvPg18p6AslUXFoLdpED4oBnGwyqk3dV1XzM=
7 changes: 6 additions & 1 deletion internal/actions/cmd/thirdpartycheck/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ var (
allowlist = []string{
// First party deps.
"cloud.google.com/go",
"github.com/GoogleCloudPlatform/",
"github.com/google/",
"github.com/googleapis/",
"github.com/golang/",
Expand All @@ -45,9 +46,13 @@ var (
"gopkg.in/yaml",
"github.com/go-git/go-git",
"github.com/apache/arrow/go",
"github.com/cloudprober/cloudprober", // https://github.com/googleapis/google-cloud-go/issues/9377

// Third party deps (temporary exception(s)).
"go.einride.tech/aip", // https://github.com/googleapis/google-cloud-go/issues/9338
"github.com/json-iterator/go", // https://github.com/googleapis/google-cloud-go/issues/9380
"github.com/stretchr/testify", // https://github.com/googleapis/google-cloud-go/issues/9378
"go.einride.tech/aip", // https://github.com/googleapis/google-cloud-go/issues/9338
"rsc.io/binaryregexp", // https://github.com/googleapis/google-cloud-go/issues/9376
}
)

Expand Down

0 comments on commit efba04d

Please sign in to comment.