Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: unflake TestIntegration_RequesterPays #1753

Closed
tritone opened this issue Jan 27, 2020 · 3 comments · Fixed by #3601
Closed

storage: unflake TestIntegration_RequesterPays #1753

tritone opened this issue Jan 27, 2020 · 3 comments · Fixed by #3601
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@tritone
Copy link
Contributor

tritone commented Jan 27, 2020 •
edited

Multiple flakes in the past week:
https://sponge.corp.google.com/target?id=3c0d95d4-29b3-4d0d-8953-0423aa0d7536&target=cloud-devrel/client-libraries/go/google-cloud-go/continuous/go113&searchFor=&show=ALL&sortBy=STATUS

https://sponge.corp.google.com/target?id=a1194c56-fd86-427a-8121-6393e31895f4&target=cloud-devrel/client-libraries/go/google-cloud-go/continuous/go112&searchFor=&show=ALL&sortBy=STATUS

    integration_test.go:3166: integration_test.go:2139: close write: googleapi: Error 429: The rate of change requests to the object go-integration-test-20200123-82263014289332-0007/foo exceeds the rate limit. Please reduce the rate of create, update, and delete requests., rateLimitExceeded

Looks like we need to introduce a short delay or retry here due to rate limits.
@tritone tritone added triage me I really want to be triaged. api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern. and removed triage me I really want to be triaged. labels Jan 27, 2020
@tritone
Copy link
Contributor Author

tritone commented Jan 27, 2020

@IlyaFaer or @AlisskaPie could you take this on?

@AlisskaPie
Copy link
Contributor

@tritone we take it

@tritone
Copy link
Contributor Author

tritone commented Jan 30, 2020

Thanks! I'm going to put in a skip for now because it has been flaking frequently.

gopherbot pushed a commit that referenced this issue Jan 30, 2020
@tritone @hongalex
storage: skip TestIntegration_RequesterPays
30f6efe 
This test has been flaking frequently; there is an issue open to
fix.

Updates #1753

Change-Id: I6210b67a154ea77085003846e04f7e36c28b07cc
Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51210
Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>
AlisskaPie added a commit to MaxxleLLC/google-cloud-go that referenced this issue Jun 11, 2020
@AlisskaPie
storage: unflake TestIntegration_RequesterPays
568072c 
Using unique object name for every operation to fix flakey

Fixes googleapis#1753

Change-Id: I1971183a6d55db38b6a30e1be94f1139f57aa565
@AlisskaPie AlisskaPie mentioned this issue Jun 11, 2020
Closed
tritone added a commit to tritone/google-cloud-go that referenced this issue Jan 23, 2021
@tritone
test(storage): Unflake TestIntegration_RequesterPays
2196dd1 
Use an additional object for the ACL section of the test to avoid
rate limit flakes.

Fixes googleapis#1753
@tritone tritone mentioned this issue Jan 23, 2021
Merged
tritone added a commit that referenced this issue Jan 26, 2021
@tritone
test(storage): Unflake TestIntegration_RequesterPays (#3601)
d634f0d 
* test(storage): Unflake TestIntegration_RequesterPays

Use an additional object for the ACL section of the test to avoid
rate limit flakes.

Fixes #1753
@tritone tritone assigned tritone and unassigned IlyaFaer and AlisskaPie Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
3 participants
@tritone @IlyaFaer @AlisskaPie