Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(storage): unflake TestIntegration_RequesterPays #2430

Closed
wants to merge 3 commits into from
Closed

test(storage): unflake TestIntegration_RequesterPays #2430

wants to merge 3 commits into from

Conversation

AlisskaPie
Copy link
Contributor

@AlisskaPie AlisskaPie commented Jun 11, 2020 •
edited

Using unique object name for every operation to fix flakey.

I have moved this CL here from Gerrit.
@tritone @frankyn thanks for reviewing it on Gerrit!

Fixes #1753

@AlisskaPie
storage: unflake TestIntegration_RequesterPays
568072c 
Using unique object name for every operation to fix flakey

Fixes googleapis#1753

Change-Id: I1971183a6d55db38b6a30e1be94f1139f57aa565
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2020
@AlisskaPie AlisskaPie marked this pull request as ready for review June 11, 2020 13:35
@AlisskaPie AlisskaPie added the api: storage Issues related to the Cloud Storage API. label Jun 12, 2020
@codyoss codyoss changed the title storage: unflake TestIntegration_RequesterPays test(storage): unflake TestIntegration_RequesterPays Aug 18, 2020
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2020
frankyn
frankyn reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems reasonable, but may pop up again unless calls are retried or random strings are introduced.

@frankyn frankyn requested a review from a team as a code owner December 3, 2020 18:44
@tritone
Copy link
Contributor

tritone commented Jan 23, 2021

Closing in favor of #3601

@tritone tritone closed this Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@tritone tritone Awaiting requested review from tritone

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: unflake TestIntegration_RequesterPays
5 participants
@AlisskaPie @tritone @frankyn @googlebot @kokoro-team