Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: option.WithTelemetryDisabled ignored #2751

Closed
filip-ph-johansson opened this issue Aug 19, 2020 · 0 comments · Fixed by #2815
Closed

pubsub: option.WithTelemetryDisabled ignored #2751

filip-ph-johansson opened this issue Aug 19, 2020 · 0 comments · Fixed by #2815
Assignees
@hongalex
Labels
api: pubsub Issues related to the Pub/Sub API. status: investigating The issue is under investigation, which is determined to be non-trivial.

Comments

@filip-ph-johansson
Copy link

Client

PubSub

Environment

macOS Catalina 10.15.4

Go Environment

$ go version
go1.14.2 darwin/amd64

Code

c, err := pubsub.NewClient(context.Background(), "GCPProjectID", option.WithTelemetryDisabled())

Expected behavior

Pubsub shouldn't push telemetry data when option.WithTelemetryDisabled is passed.

Actual behavior

The following Pubsub traces are pushed to GCP Trace:
Sent.google.pubsub.v1.Subscriber.Acknowledge
Sent.google.pubsub.v1.Subscriber.ModifyAckDeadline
Sent.google.pubsub.v1.Publisher.Publish
@filip-ph-johansson filip-ph-johansson added the triage me I really want to be triaged. label Aug 19, 2020
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Aug 19, 2020
@hongalex hongalex added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Aug 20, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Aug 20, 2020
@codyoss codyoss mentioned this issue Sep 2, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 3, 2020
@codyoss
fix(pubsub): honor option.WithTelemetryDisabled (#2815)
00cf7a1 
It seem that the telemetry options added here predate general
telemetry handling. There is no need to explicitly enable such
options here as it is taken care of grpc.DialPool:
https://pkg.go.dev/google.golang.org/api/transport/grpc?#DialPool.
The stats handler is only added if option.WithTelemetryDisabled is
not passed in.

Fixes: #2751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongalex hongalex

Labels
api: pubsub Issues related to the Pub/Sub API. status: investigating The issue is under investigation, which is determined to be non-trivial.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pubsub): honor option.WithTelemetryDisabled
3 participants
@filip-ph-johansson @hongalex @yoshi-automation