fix(pubsub): honor option.WithTelemetryDisabled #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seem that the telemetry options added here predate general telemtry handling. There is no need to explicitly enable such options here as it is taken care of grpc.DialPool: https://pkg.go.dev/google.golang.org/api/transport/grpc?tab=doc#DialPool. The stats handler is only added if option.WithTelemetryDisabled is not passed in. Fixes: #2751
google-cla
bot
added
the
cla: yes
|
Here is where the option is added in the private dial function. |
codyoss
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seem that the telemetry options added here predate general
telemetry handling. There is no need to explicitly enable such
options here as it is taken care of grpc.DialPool:
https://pkg.go.dev/google.golang.org/api/transport/grpc?#DialPool.
The stats handler is only added if option.WithTelemetryDisabled is
not passed in.
Fixes: #2751