Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: remove tool dependencies from library go.mods #4061

Closed
tbpg opened this issue May 5, 2021 · 0 comments · Fixed by #4580
Closed

all: remove tool dependencies from library go.mods #4061

tbpg opened this issue May 5, 2021 · 0 comments · Fixed by #4580
Assignees
@codyoss
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@tbpg
Copy link
Contributor

tbpg commented May 5, 2021

For example, github.com/jstemmer/go-junit-report is only used for CI, but it shows up in our dependency tree. We should fix that.

I don't have a preference between pre-installing in the Docker image or having a tools go.mod.
@tbpg tbpg added the type: cleanup An internal cleanup or hygiene concern. label May 5, 2021
This was referenced Aug 9, 2021
Merged
Merged
gcf-merge-on-green bot pushed a commit to googleapis/testing-infra-docker that referenced this issue Aug 9, 2021
@codyoss
feat(go): add testing deps to images (#161)
c530aac 
Updates: googleapis/google-cloud-go#4061
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 13, 2021
@codyoss
feat(all): remove testing deps (#4580)
15c1eb9 
This is a follow up for googleapis/testing-infra-docker#161.

Fixes: #4061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(all): remove testing deps
2 participants
@codyoss @tbpg