Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: package should be able to report errors #728

Closed
rakyll opened this issue Aug 14, 2017 · 3 comments
Closed

errors: package should be able to report errors #728

rakyll opened this issue Aug 14, 2017 · 3 comments
Assignees
Labels
api: clouderrorreporting Issues related to the Error Reporting API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Comments

@rakyll
Copy link
Contributor

rakyll commented Aug 14, 2017

errors package only provides reporting of log messages and recovery and report of panics. The package instead should provide APIs that can report Go errors.

I suggest to change the Report API to work against an error:

func (c *Client) Report(ctx context.Context, r *http.Request, err error)

Then, we can also remove the Reportf and users can use fmt.Errorf if they want to include more context to the error messages.

/cc @jba @zombiezen

@rakyll rakyll added the api: clouderrorreporting Issues related to the Error Reporting API. label Aug 14, 2017
@rakyll rakyll self-assigned this Aug 14, 2017
@zombiezen
Copy link
Contributor

SGTM, especially if there's more error introspection that we can do (integrate with github.com/pkg/errors, maybe?).

@rakyll
Copy link
Contributor Author

rakyll commented Aug 15, 2017

I am happy to recognize github.com/pkg/errors errors and attach stack trace to the report if available.

@rakyll rakyll added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Aug 15, 2017
@zombiezen
Copy link
Contributor

I was thinking more long-term. For now, let's just make the change to the function signature.

yoshi-automation added a commit that referenced this issue Aug 2, 2022
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#870

Changes:

docs(container): BinaryAuthorization.enabled field is marked as deprecated
  PiperOrigin-RevId: 464729666
  Source-Link: googleapis/googleapis@c77c067

feat(retail): new model service to manage recommendation models feat: support case insensitive match on search facets feat: allow disabling spell check in search requests feat: allow adding labels in search requests feat: allow returning min/max values on search numeric facets feat: allow using serving configs as an alias of placements feat: allow enabling recommendation filtering on custom attributes feat: return output BigQuery table on product / event export response feat: allow skiping default branch protection when doing product full import docs: keep the API doc up-to-date with recent changes
  PiperOrigin-RevId: 464664497
  Source-Link: googleapis/googleapis@c30c9cc

chore(compute): add py_test target for compute (#728)

  Source-Link: googleapis/googleapis@d7f7568

fix(datacatalog)!: fix datacatalog resource name config
  PiperOrigin-RevId: 464572702
  Source-Link: googleapis/googleapis@9f82a84

chore(bigquery/connection): deprecate the AwsCrossAccountRole property
  feat: add Azure Properties to Connection

  Azure properties are used by BigQuery Omni in Azure regions.

  PiperOrigin-RevId: 464570667
  Source-Link: googleapis/googleapis@75905af

feat(retail): support case insensitive match on search facets feat: allow to return min/max values on search numeric facets feat: allow to use serving configs as an alias of placements docs: keep the API doc up-to-date with recent changes
  PiperOrigin-RevId: 464560246
  Source-Link: googleapis/googleapis@139f56e
yoshi-automation added a commit that referenced this issue Aug 2, 2022
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#870

Changes:

docs(container): BinaryAuthorization.enabled field is marked as deprecated
  PiperOrigin-RevId: 464729666
  Source-Link: googleapis/googleapis@c77c067

feat(retail): new model service to manage recommendation models feat: support case insensitive match on search facets feat: allow disabling spell check in search requests feat: allow adding labels in search requests feat: allow returning min/max values on search numeric facets feat: allow using serving configs as an alias of placements feat: allow enabling recommendation filtering on custom attributes feat: return output BigQuery table on product / event export response feat: allow skiping default branch protection when doing product full import docs: keep the API doc up-to-date with recent changes
  PiperOrigin-RevId: 464664497
  Source-Link: googleapis/googleapis@c30c9cc

chore(compute): add py_test target for compute (#728)

  Source-Link: googleapis/googleapis@d7f7568

fix(datacatalog)!: fix datacatalog resource name config
  PiperOrigin-RevId: 464572702
  Source-Link: googleapis/googleapis@9f82a84

chore(bigquery/connection): deprecate the AwsCrossAccountRole property
  feat: add Azure Properties to Connection

  Azure properties are used by BigQuery Omni in Azure regions.

  PiperOrigin-RevId: 464570667
  Source-Link: googleapis/googleapis@75905af

feat(retail): support case insensitive match on search facets feat: allow to return min/max values on search numeric facets feat: allow to use serving configs as an alias of placements docs: keep the API doc up-to-date with recent changes
  PiperOrigin-RevId: 464560246
  Source-Link: googleapis/googleapis@139f56e
codyoss pushed a commit that referenced this issue Aug 2, 2022
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#870

Changes:

docs(container): BinaryAuthorization.enabled field is marked as deprecated
  PiperOrigin-RevId: 464729666
  Source-Link: googleapis/googleapis@c77c067

feat(retail): new model service to manage recommendation models feat: support case insensitive match on search facets feat: allow disabling spell check in search requests feat: allow adding labels in search requests feat: allow returning min/max values on search numeric facets feat: allow using serving configs as an alias of placements feat: allow enabling recommendation filtering on custom attributes feat: return output BigQuery table on product / event export response feat: allow skiping default branch protection when doing product full import docs: keep the API doc up-to-date with recent changes
  PiperOrigin-RevId: 464664497
  Source-Link: googleapis/googleapis@c30c9cc

chore(compute): add py_test target for compute (#728)

  Source-Link: googleapis/googleapis@d7f7568

fix(datacatalog): fix datacatalog resource name config
  PiperOrigin-RevId: 464572702
  Source-Link: googleapis/googleapis@9f82a84

chore(bigquery/connection): deprecate the AwsCrossAccountRole property
  feat: add Azure Properties to Connection

  Azure properties are used by BigQuery Omni in Azure regions.

  PiperOrigin-RevId: 464570667
  Source-Link: googleapis/googleapis@75905af

feat(retail): support case insensitive match on search facets feat: allow to return min/max values on search numeric facets feat: allow to use serving configs as an alias of placements docs: keep the API doc up-to-date with recent changes
  PiperOrigin-RevId: 464560246
  Source-Link: googleapis/googleapis@139f56e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the Error Reporting API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Development

No branches or pull requests

2 participants