-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errorreporting: don't provide logging #736
Labels
api: clouderrorreporting
Issues related to the Error Reporting API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
🚨
This issue needs some love.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
Please provide input, I can remove the logger as a part of https://code-review.googlesource.com/c/gocloud/+/16090. |
Fixed by 8b73297. |
yoshi-automation
added a commit
that referenced
this issue
Oct 24, 2022
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#927 Changes: feat(dialogflow): Can directly set Cloud Speech model on the SpeechToTextConfig PiperOrigin-RevId: 482665674 Source-Link: googleapis/googleapis@64926d5 docs(dialogflow/cx): Clarified TTL as time-to-live docs: Removed pre-GA disclaimer from Interaction Logging (has been GA for awhile) PiperOrigin-RevId: 482618841 Source-Link: googleapis/googleapis@62443cf feat(compute): Update Compute Engine API to revision 20221011 (#736) Source-Link: googleapis/googleapis@cb8c914 feat(pubsub): Provide easier access to IAM via the standard IAMPolicy client class PiperOrigin-RevId: 482013889 Source-Link: googleapis/googleapis@5f68158 feat(kms): Provide easier access to IAM via the standard IAMPolicy client class PiperOrigin-RevId: 482013711 Source-Link: googleapis/googleapis@6d38b26
yoshi-automation
added a commit
that referenced
this issue
Oct 24, 2022
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#927 Changes: feat(dialogflow): Can directly set Cloud Speech model on the SpeechToTextConfig PiperOrigin-RevId: 482665674 Source-Link: googleapis/googleapis@64926d5 docs(dialogflow/cx): Clarified TTL as time-to-live docs: Removed pre-GA disclaimer from Interaction Logging (has been GA for awhile) PiperOrigin-RevId: 482618841 Source-Link: googleapis/googleapis@62443cf feat(compute): Update Compute Engine API to revision 20221011 (#736) Source-Link: googleapis/googleapis@cb8c914 feat(pubsub): Provide easier access to IAM via the standard IAMPolicy client class PiperOrigin-RevId: 482013889 Source-Link: googleapis/googleapis@5f68158 feat(kms): Provide easier access to IAM via the standard IAMPolicy client class PiperOrigin-RevId: 482013711 Source-Link: googleapis/googleapis@6d38b26
codyoss
added a commit
that referenced
this issue
Oct 24, 2022
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#927 Changes: feat(dialogflow): Can directly set Cloud Speech model on the SpeechToTextConfig PiperOrigin-RevId: 482665674 Source-Link: googleapis/googleapis@64926d5 docs(dialogflow/cx): Clarified TTL as time-to-live docs: Removed pre-GA disclaimer from Interaction Logging (has been GA for awhile) PiperOrigin-RevId: 482618841 Source-Link: googleapis/googleapis@62443cf feat(compute): Update Compute Engine API to revision 20221011 (#736) Source-Link: googleapis/googleapis@cb8c914 feat(pubsub): Provide easier access to IAM via the standard IAMPolicy client class PiperOrigin-RevId: 482013889 Source-Link: googleapis/googleapis@5f68158 feat(kms): Provide easier access to IAM via the standard IAMPolicy client class PiperOrigin-RevId: 482013711 Source-Link: googleapis/googleapis@6d38b26 Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
Merged
kimihrr
pushed a commit
to kimihrr/google-cloud-go-kimia
that referenced
this issue
Oct 25, 2022
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#927 Changes: feat(dialogflow): Can directly set Cloud Speech model on the SpeechToTextConfig PiperOrigin-RevId: 482665674 Source-Link: googleapis/googleapis@64926d5 docs(dialogflow/cx): Clarified TTL as time-to-live docs: Removed pre-GA disclaimer from Interaction Logging (has been GA for awhile) PiperOrigin-RevId: 482618841 Source-Link: googleapis/googleapis@62443cf feat(compute): Update Compute Engine API to revision 20221011 (googleapis#736) Source-Link: googleapis/googleapis@cb8c914 feat(pubsub): Provide easier access to IAM via the standard IAMPolicy client class PiperOrigin-RevId: 482013889 Source-Link: googleapis/googleapis@5f68158 feat(kms): Provide easier access to IAM via the standard IAMPolicy client class PiperOrigin-RevId: 482013711 Source-Link: googleapis/googleapis@6d38b26 Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: clouderrorreporting
Issues related to the Error Reporting API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
🚨
This issue needs some love.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
As a result of #728, errorreporting package will work specifically against the errors. The package currently logs to Stackdriver Logging if it is configured so, but we should remove this functionality and allow users to depend on the logging package to report the error message instead. By doing so, we are also giving them opportunity to add more context to the log message.
/cc @zombiezen
The text was updated successfully, but these errors were encountered: