Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: using deprecated repo of proto #9189

Closed
eyalAlpha opened this issue Dec 20, 2023 · 1 comment · Fixed by #9232
Closed

storage: using deprecated repo of proto #9189

eyalAlpha opened this issue Dec 20, 2023 · 1 comment · Fixed by #9232
Assignees
@noahdietz
Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@eyalAlpha
Copy link

Client
storage

The latest version for go 1.20, v1.36.0, is using a deprecated repo github.com/golang/protobuf v1.5.3 that should be replaced to google.golang.org/protobuf.
@eyalAlpha eyalAlpha added the triage me I really want to be triaged. label Dec 20, 2023
@codyoss codyoss changed the title cloud.google.com/go/storage: using deprecated repo of proto storage: using deprecated repo of proto Dec 20, 2023
@codyoss codyoss added the api: storage Issues related to the Cloud Storage API. label Dec 20, 2023
@noahdietz noahdietz assigned noahdietz and unassigned tritone Jan 8, 2024
@noahdietz noahdietz added type: cleanup An internal cleanup or hygiene concern. and removed triage me I really want to be triaged. labels Jan 8, 2024
@noahdietz
Copy link
Contributor

Thanks @eyalAlpha for pointing that out. It is only included in an integration test. Simple to remove.

@noahdietz noahdietz mentioned this issue Jan 8, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 8, 2024
@noahdietz
fix(storage): migrate deprecated proto dep (#9232)
ebbb610 
Migrates test usage of protobuf-go v1 lib to protobuf-go v2 lib.

Also migrates deprecated `ioutil` APIs to equivalent `os` APIs.

Fixes #9189
@release-please release-please bot mentioned this issue Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storage): migrate deprecated proto dep noahdietz/google-cloud-go
4 participants
@tritone @codyoss @noahdietz @eyalAlpha