Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): migrate deprecated proto dep #9232

Merged
merged 3 commits into from
Jan 8, 2024
Merged

fix(storage): migrate deprecated proto dep #9232

merged 3 commits into from
Jan 8, 2024

Conversation

noahdietz
Copy link
Contributor

Migrates test usage of protobuf-go v1 lib to protobuf-go v2 lib.

Also migrates deprecated ioutil APIs to equivalent os APIs.

Fixes #9189

@noahdietz noahdietz requested review from a team as code owners January 8, 2024 19:30
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Jan 8, 2024
@noahdietz
Copy link
Contributor Author

Note: This commit is a fix --> patch release. LMK if you want it changed to chore (won't trigger a release/show in notes)

tritone
tritone approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Noah!

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Jan 8, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit ebbb610 into googleapis:main Jan 8, 2024
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 8, 2024
@release-please release-please bot mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: using deprecated repo of proto
3 participants
@noahdietz @tritone @BrennaEpp