Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pkg doc on timeouts #2739

Merged
merged 10 commits into from
Aug 28, 2020

Conversation

noahdietz
Copy link
Contributor

This updates the cloud.google.com/go package documentation regarding timeouts to include the upcoming default deadline changes.

This change should be included once regeneration with default deadlines happens.

Motivated by work on googleapis/gapic-generator-go#411

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2020
@noahdietz
Copy link
Contributor Author

noahdietz commented Aug 17, 2020

I'm going to leave this open until I've released the new generator version, updated it here, and regen has occurred

doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
@noahdietz noahdietz removed the request for review from broady August 18, 2020 15:28
noahdietz and others added 4 commits August 18, 2020 08:29
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noahdietz noahdietz merged commit 7a8607e into googleapis:master Aug 28, 2020
@noahdietz noahdietz deleted the default-deadline-docs branch August 28, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants