Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): change pubsub.Message.ID to an encoded publish.Metadata #3662

Merged
merged 3 commits into from Feb 4, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Feb 3, 2021

This mirrors the Java implementation: googleapis/java-pubsublite#482. If the user's custom message transformer sets the pubsub.Message.ID, the SubscriberClient will terminate with error. The internal wire subscriber needs to pass the partition number to the CPS subscriber shim via ReceivedMessage.

Updated tests and documentation. Changed the comments for publish.ParseMetadata to inline documentation examples.

@tmdiep
Copy link
Contributor Author

@tmdiep tmdiep commented Feb 3, 2021

Note: as was done for the Java lib in googleapis/java-pubsublite#482, we will rename the publish metadata to MessageMetadata. This will be done in a subsequent PR to isolate unrelated changes and add other reviewers for the public API change.

@tmdiep tmdiep merged commit 6b2807f into googleapis:master Feb 4, 2021
3 checks passed
@tmdiep tmdiep deleted the message_id branch Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants