Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/apidiff): fix incompat check retry #4094

Merged
merged 2 commits into from May 12, 2021

Conversation

noahdietz
Copy link
Contributor

Fixes a typo (using the wrong flag) on the incompatibility check retry attempt.

Adds a -gapic flag to enable running this differ against just one package.

* add -gapic flag to diff just one package
@noahdietz noahdietz requested a review from a team as a code owner May 12, 2021 20:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2021
@noahdietz noahdietz merged commit 2ec1912 into googleapis:master May 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2021
@noahdietz noahdietz deleted the fix-apidiff branch May 12, 2021 21:46
tbpg pushed a commit that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants