Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix Writer.ChunkSize validation #4255

Merged
merged 2 commits into from Jun 14, 2021

Conversation

@tritone
Copy link
Collaborator

@tritone tritone commented Jun 14, 2021

Since w.opened is set to true before this validation currently,
subsequent calls to Writer.Close will deadlock. There is no
reason not to do this check first before opening the pipe.

Thanks to @dt for pointing this out.

Updates #4167

Since w.opened is set to true before this validation currently,
subsequent calls to Writer.Close will deadlock. There is no
reason not to do this check first before opening the pipe.

Thanks to @dt for pointing this out.

Updates googleapis#4167
@tritone tritone requested a review from Jun 14, 2021
@tritone tritone requested a review from as a code owner Jun 14, 2021
@google-cla google-cla bot added the cla: yes label Jun 14, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

Loading

@gcf-merge-on-green gcf-merge-on-green bot merged commit 69c2e9d into googleapis:master Jun 14, 2021
4 checks passed
Loading
@tritone tritone deleted the chunksize-fix branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants