feat(internal/detect): add helper to detect projectID from env#4582
Merged
codyoss merged 5 commits intogoogleapis:masterfrom Aug 13, 2021
codyoss:detect-project
Merged
feat(internal/detect): add helper to detect projectID from env#4582codyoss merged 5 commits intogoogleapis:masterfrom codyoss:detect-project
codyoss merged 5 commits intogoogleapis:masterfrom
codyoss:detect-project
Conversation
google-cla
bot
added
the
cla: yes
Member
Author
|
cc @crwilcox Some of your libraries can use this in the future. I think you brought this up not too long ago... |
noahdietz
approved these changes
Aug 9, 2021
Contributor
noahdietz
left a comment
noahdietz
left a comment
There was a problem hiding this comment.
LGTM but is there a way to add a test?
Contributor
|
How does this differ from https://github.com/googleapis/google-cloud-go/blob/master/firestore/client.go#L83 / https://github.com/googleapis/google-cloud-go/blob/master/firestore/client.go#L104 Is the goal here to centralize this as most veneers have this (more or less) duplicated code? |
Member
Author
Yes. Just wanted to have a consistent implementation for all to use. |
Member
Author
|
@noahdietz Done. |
codyoss
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to be used by certain veneers so that we can detect the projectID in a consistent manner. Future PRs will use this logic.
Fixes: #1294