chore(storage): add proto converters for Object metadata #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
noahdietz
force-pushed
the
storage-attrs
branch
6 times, most recently
from
9888779
to
880454a
Compare
noahdietz
force-pushed
the
storage-attrs
branch
3 times, most recently
from
b83994e
to
123a6b6
Compare
noahdietz
force-pushed
the
storage-attrs
branch
from
123a6b6
to
830c7b9
Compare
tritone
reviewed
Aug 20, 2021
| Acl: toProtoObjectACL(o.ACL), | ||
| Metadata: o.Metadata, | ||
| CustomTime: ct, | ||
| KmsKey: o.KMSKeyName, |
There was a problem hiding this comment.
Why is it necessary to add this field here and not in the apiary object?
There was a problem hiding this comment.
Idk if it's necessary or not, but it's in the proto so I included it here. Should I remove it?
There was a problem hiding this comment.
Hmm, looks like it might be an oversight in the current implementation which is concerning!
| Deleted: convertProtoTime(o.GetDeleteTime()), | ||
| Updated: convertProtoTime(o.GetUpdateTime()), | ||
| CustomTime: convertProtoTime(o.GetCustomTime()), | ||
| } |
There was a problem hiding this comment.
I noticed ETag is missing, is that no longer provided via gRPC?
There was a problem hiding this comment.
There isn't an etag field in the protos so I guess not.
noahdietz
changed the title
|
@tritone I've added test cases PTAL! |
tritone
reviewed
Aug 24, 2021
| Acl: toProtoObjectACL(o.ACL), | ||
| Metadata: o.Metadata, | ||
| CustomTime: ct, | ||
| KmsKey: o.KMSKeyName, |
There was a problem hiding this comment.
Hmm, looks like it might be an oversight in the current implementation which is concerning!
tritone
approved these changes
Aug 25, 2021
BrennaEpp
pushed a commit
to BrennaEpp/google-cloud-go
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds converters for the various metadata types, between the library version and the protobuf version.